Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes for allowed_groups and admin_groups #758

Merged
merged 12 commits into from
Sep 3, 2024
Merged

Various fixes for allowed_groups and admin_groups #758

merged 12 commits into from
Sep 3, 2024

Commits on Sep 2, 2024

  1. Systematically test allowed_groups, admin_groups, and manage_groups

    @consideRatio
    consideRatio committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    e7c2e09 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. docs: update example for Generic to use non-deprecated config

    @consideRatio
    consideRatio committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    3d79615 View commit details
    Browse the repository at this point in the history

  2. tests: verify deprecation message for GenericOAuthenticator.claim_gro… 

    …ups_key
    @consideRatio
    consideRatio committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    79ef403 View commit details
    Browse the repository at this point in the history

  3. tests: iterate on allowed_groups and admin_groups tests

    @consideRatio
    consideRatio committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    da158fe View commit details
    Browse the repository at this point in the history

  4. apply manage_groups behavior outside update_auth_model 

    always applied last, not overrideable by subclasses.

Subclasses govern this behavior via `get_user_groups`
    @minrk
    minrk committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    d9ac90e View commit details
    Browse the repository at this point in the history

  5. fix auth_state_groups_key example in docs 

    add oauth_user
    @minrk
    minrk committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    baca8a4 View commit details
    Browse the repository at this point in the history

  6. openshift: rely on base class implementation for allowed_groups and a… 

    …dmin_groups
    @consideRatio
    consideRatio committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    115ceee View commit details
    Browse the repository at this point in the history

  7. openshift: test equivalent of default auth_state_groups_key provided … 

    …as before
    @consideRatio
    consideRatio committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6618811 View commit details
    Browse the repository at this point in the history

  8. tests: verify deprecation message for AzureAdOAuthenticator.user_grou… 

    …ps_claim
    @consideRatio
    consideRatio committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c16bb8c View commit details
    Browse the repository at this point in the history

  9. docs: update azuread docs about auth_state_groups_key

    @consideRatio
    consideRatio committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f92b511 View commit details
    Browse the repository at this point in the history

  10. azuread: retain default of deprecated user_groups_claim within auth_s… 

    …tate_groups_key
    @consideRatio
    consideRatio committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    05778cd View commit details
    Browse the repository at this point in the history

  11. docs: mention allowed_groups and admin_groups in general setup

    @consideRatio
    consideRatio committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9e5520d View commit details
    Browse the repository at this point in the history