Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incident report for hub 403 incident on Sep 27 2017 #12

Merged
merged 2 commits into from
Sep 29, 2017
Merged

Conversation

yuvipanda
Copy link
Contributor

No description provided.


1. Local development environment being slightly different from production
environment (single node vs multi node)
2. Testing in staging not thorough enough
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add one more thing, which is: "changing lots of things at the same time." It sounds like a reason this was hard to debug is that we have a few different moving pieces that we're juggling (e.g., jupyterhub will be upgraded soon and that'll "just fix" some problems) that caused us to miss this. Not much we can do about that short-term as a lot of this code is evolving rapidly, but good to keep in mind to try keeping our # of changed variables at a minimum on each iteration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added note!


## Local development

1. Consider figuring out an easy way for people to run a development environment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an important point to me...any other possibilities than using another cloud instance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I amended this PR with a link to an issue I opened about this with a possible solution: jupyterhub/binderhub#137

@yuvipanda yuvipanda merged commit 6564993 into master Sep 29, 2017
@yuvipanda yuvipanda deleted the incident-1 branch September 29, 2017 02:07
@yuvipanda
Copy link
Contributor Author

Merging this since I'm about to perform some other git surgery. Feel free to continue to leave comments here!

@minrk
Copy link
Member

minrk commented Sep 29, 2017

Hooray for incident reports!

@minrk
Copy link
Member

minrk commented Sep 29, 2017

An external test battery to run against an existing deployment would also be useful. We could make sure that runs against staging before deploying to prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants