Skip to content

Commit

Permalink
Merge pull request #128 from mathbunnyru/asalikhov/do_not_pass_cmd
Browse files Browse the repository at this point in the history
Use default cmd for running jupyter/docker-stacks
  • Loading branch information
minrk authored Aug 28, 2023
2 parents 89a2962 + d9f6cf1 commit 07b4883
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
2 changes: 0 additions & 2 deletions basic-example/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ services:
DOCKER_NOTEBOOK_IMAGE: jupyter/base-notebook:latest
# Notebook directory inside user image
DOCKER_NOTEBOOK_DIR: /home/jovyan/work
# Using this run command
DOCKER_SPAWN_CMD: start-singleuser.sh

volumes:
jupyterhub-data:
Expand Down
8 changes: 0 additions & 8 deletions basic-example/jupyterhub_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,6 @@
# Spawn containers from this image
c.DockerSpawner.image = os.environ["DOCKER_NOTEBOOK_IMAGE"]

# JupyterHub requires a single-user instance of the Notebook server, so we
# default to using the `start-singleuser.sh` script included in the
# jupyter/docker-stacks *-notebook images as the Docker run command when
# spawning containers. Optionally, you can override the Docker run command
# using the DOCKER_SPAWN_CMD environment variable.
spawn_cmd = os.environ.get("DOCKER_SPAWN_CMD", "start-singleuser.sh")
c.DockerSpawner.cmd = spawn_cmd

# Connect containers to this Docker network
network_name = os.environ["DOCKER_NETWORK_NAME"]
c.DockerSpawner.use_internal_ip = True
Expand Down

0 comments on commit 07b4883

Please sign in to comment.