Skip to content

Commit

Permalink
Remove warning about only supporting go-jsonnet
Browse files Browse the repository at this point in the history
I've always used the regular jsonnet implementation without trouble,
and continue to do so.

It's technically slower, but at these scales it does not matter. It's
also the default you get if you do `brew install jsonnet` or
`apt install jsonnet`.
  • Loading branch information
yuvipanda committed Jul 26, 2024
1 parent 525c48c commit f4ce9bd
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions deploy.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,18 +130,12 @@ def main():
"The environment variable GRAFANA_TOKEN needs to be set in order to deploying dashboards to a Grafana deployment."
)

# ensure jsonnet (go-jsonnet)
# ensure jsonnet
if not shutil.which("jsonnet"):
raise ValueError(
"No jsonnet binary was found on path! "
"Install go-jsonnet via https://github.com/google/go-jsonnet/releases."
)
jsonnet_version = subprocess.check_output(["jsonnet", "--version"], text=True)
if "go" not in jsonnet_version.casefold():
print(
"WARNING: The jsonnet binary on path doesn't seem to be go-jsonnet from https://github.com/google/go-jsonnet/releases! "
"Only that jsonnet implementation is known to work."
)

api = partial(
grafana_request,
Expand Down

0 comments on commit f4ce9bd

Please sign in to comment.