require Python 3.9, jupyterhub 4, unpin pytest-asyncio #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test fixtures are too complex to support for outdated jupyterhub python 3.8 is past security EOL
minrk
changed the title
minrk
force-pushed
the
revert-514-pytest-asyncio
branch
from
bcaf679 to
237e686
Compare
|
increased required python to 3.9 (oldest Python with security support), jupyterhub to 4 (oldest jupyterhub without known vulnerabilities) because the imported jupyterhub fixtures have complex interactions with pytest-asyncio going back too many versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increase lower bound on pytest-asyncio to 0.24
this may create a problem for the older jupyterhub tests due to imported fixtures, but let's see...