Skip to content

Commit

Permalink
pin pytest-asyncio for outdated jupyterhub
Browse files Browse the repository at this point in the history
  • Loading branch information
minrk committed Feb 12, 2025
1 parent 237e686 commit 72c5580
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,13 @@ jobs:
fail-fast: false
matrix:
include:
# jupyterhub 4 works with pytest-asyncio 0.25
# but requires some deprecated features,
# so don't let it upgrade further
- python-version: "3.9"
pip-install-spec: "jupyterhub==4.* sqlalchemy==1.*"
pip-install-spec: "jupyterhub==4.* sqlalchemy==1.* pytest-asyncio==0.25.*"
- python-version: "3.11"
pip-install-spec: "jupyterhub==4.*"
pip-install-spec: "jupyterhub==4.* pytest-asyncio==0.25.*"
test-variation: podman
- python-version: "3.12"
pip-install-spec: "jupyterhub==5.*"
Expand Down
2 changes: 1 addition & 1 deletion dev-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
netifaces
notebook<7
pytest>=3.6
pytest-asyncio>=0.24
pytest-asyncio>=0.25
pytest-cov
5 changes: 5 additions & 0 deletions tests/conftest.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
"""pytest config for dockerspawner tests"""

import inspect
import json
import os
from textwrap import indent
Expand All @@ -18,6 +19,10 @@
from jupyterhub.tests.conftest import user # noqa: F401
from jupyterhub.tests.mocking import MockHub

if 'event_loop' in inspect.signature(io_loop).parameters:
# older JupyterHub (< 5.x), io_loop requires deprecated event_loop
from jupyterhub.tests.conftest import event_loop # noqa: F401

from dockerspawner import DockerSpawner, SwarmSpawner, SystemUserSpawner

# import base jupyterhub fixtures
Expand Down

0 comments on commit 72c5580

Please sign in to comment.