Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Access-Control-Allow-Origin=* on /versions API #1906

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

agoose77
Copy link

@agoose77 agoose77 commented Jan 9, 2025

This PR is the BinderHub counterpart to jupyterhub/jupyterhub#4966. It is intended to expose the unauthenticated /versions API call to cross-origin queries, enabling use in contexts where CORS would otherwise prohibit the fetch.

By merging this PR, all BinderHub deployments will now be able to answer a question of the form "are you a BinderHub", which is useful for us over in the Jupyter Book ecosystem (see the above PR!)

I took the same approach here as JupyterHub, so I hope it's not a contentious PR!

@agoose77
Copy link
Author

Thanks for the approval @minrk :)

I assume that the failed test job is unrelated to this PR.

@manics
Copy link
Member

manics commented Jan 14, 2025

The original test run failed due to an external problem, I've rerun them and this looks like a genuine error, all tests are passing on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants