Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the frontend #1856

Merged
merged 99 commits into from
Jan 3, 2025
Merged
Changes from 1 commit
Commits
Show all changes
99 commits
Select commit Hold shift + click to select a range
31910bc
Rewrite the frontend completely
yuvipanda May 15, 2024
5c1183f
Split homepage into its own file
yuvipanda May 17, 2024
2e2a3ea
Add a loading page
yuvipanda May 18, 2024
55e0a41
Add nbviewer support
yuvipanda May 18, 2024
bb480e8
Re-implement the loader animation & text
yuvipanda May 18, 2024
f63e9b9
Update favicon correctly based on phases
yuvipanda May 18, 2024
ea7dbe7
Remove and cleanup unused stuff
yuvipanda May 18, 2024
abbf864
Add more type annotations
yuvipanda May 18, 2024
5661f17
Fix a few more typescript detected errors
yuvipanda May 18, 2024
b02256e
Don't enforce strict type checks yet
yuvipanda May 18, 2024
ffb3884
Create a central spec class
yuvipanda May 18, 2024
d6b549f
Document & rename spec class to be better
yuvipanda May 23, 2024
5da4111
Pass launchSpec correctly
yuvipanda May 23, 2024
23e491e
Remove GA code, add back extra_footer_scripts
yuvipanda May 23, 2024
b5c1c38
Move redirect calculation to Spec object
yuvipanda May 24, 2024
1bc530a
Remove unused static font
yuvipanda May 24, 2024
e4becd7
Move about page to frontend rendering
yuvipanda May 24, 2024
5a6adac
Fix case of component file
yuvipanda May 29, 2024
354118a
Remove remaining reference to `_config`
yuvipanda May 29, 2024
484680b
Support setting banner message
yuvipanda Jul 1, 2024
3e31936
Merge remote-tracking branch 'upstream/main' into closure
yuvipanda Jul 12, 2024
0ad9347
Remove unused functionality from binderhub-client
yuvipanda Jul 12, 2024
ea9d565
Add functionality to view logs in raw form
yuvipanda Jul 31, 2024
2c9d89f
Kill some unnecessary useEffects
yuvipanda Aug 1, 2024
7c55383
Add badge generator
yuvipanda Aug 2, 2024
c65214d
Merge remote-tracking branch 'upstream/main' into closure
yuvipanda Aug 2, 2024
c46a691
Add OpenGraph social card support
yuvipanda Aug 3, 2024
f942938
Fix copy buttons
yuvipanda Aug 3, 2024
ab59cb1
Tweak style of badge generator a little
yuvipanda Aug 3, 2024
97f1bfd
Fix lint
oliverroick Nov 21, 2024
e858fa8
Ignore spec.js in tests
oliverroick Nov 21, 2024
a4733b4
gitignore coverage directory
oliverroick Nov 21, 2024
6193fb1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 21, 2024
ae035cb
Add basic link-generator tests
oliverroick Nov 22, 2024
5b7329a
Fix repo-select input group layout
oliverroick Nov 22, 2024
ce6a4bc
Fix label alignment
oliverroick Nov 22, 2024
e70e260
Replace links with buttons in dropdowns
oliverroick Nov 22, 2024
729b563
Add Github and Zenodo test cases
oliverroick Nov 22, 2024
1d6e8d4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 22, 2024
d92e6b7
Remove test for custom template
yuvipanda Nov 27, 2024
85113b0
Remove about handler test
yuvipanda Nov 27, 2024
28dc23c
Add router test for homepage and about page
oliverroick Nov 27, 2024
d8816cf
Remove template based custom error and 404 pages
yuvipanda Nov 27, 2024
ddf6371
Don't stop after only 2 test failures
yuvipanda Nov 27, 2024
54f6e04
Add Not Found page
oliverroick Nov 28, 2024
7c2035a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 28, 2024
2c87b24
Run test_loading_page with Playwright
oliverroick Dec 5, 2024
cf1e6cc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 5, 2024
cc4b551
s/status_code/status/ for playwright response object
yuvipanda Dec 6, 2024
22b8366
Remove excessive inline comments
yuvipanda Dec 7, 2024
74a71b7
Remove unnecessary pytest mark
yuvipanda Dec 7, 2024
26ec60f
Install firefox for tests, not chrome
yuvipanda Dec 7, 2024
422d383
Dynamically determine port binderhub listens on
yuvipanda Dec 7, 2024
50f2879
Merge branch 'binderhub-local' into closure
yuvipanda Dec 8, 2024
279e232
Fix tests to match rewrite
yuvipanda Dec 8, 2024
1965809
Add handling for misconfigured specs
oliverroick Dec 9, 2024
cc09f36
Remove encoded url from loading-page test
oliverroick Dec 9, 2024
cf6a2ee
Verify by matching URL
oliverroick Dec 9, 2024
55d4318
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 9, 2024
3ee5069
Remove 'some errors disappear' error
yuvipanda Dec 9, 2024
f26d970
Merge remote-tracking branch 'upstream/main' into closure
yuvipanda Dec 9, 2024
a6522be
Add note about nbviewer URL
yuvipanda Dec 9, 2024
d16f2ea
Support build tokens
yuvipanda Dec 9, 2024
aa19f64
Handle situation where ref isn't enabled
yuvipanda Dec 12, 2024
a947c82
Validate spec for each repo provider separately
yuvipanda Dec 12, 2024
78bcdbf
Fix JS unit tests
oliverroick Dec 12, 2024
771b52b
Add info about wether repo should be urlencoded or not
yuvipanda Dec 12, 2024
8d0f089
Switch from react-router v6 to wouter
yuvipanda Dec 12, 2024
424f831
Generate build tokens correctly
yuvipanda Dec 12, 2024
ba212f5
Fix *some* jest tests
yuvipanda Dec 13, 2024
2f2b327
Fix route regex in Jest config
oliverroick Dec 13, 2024
b30a9e9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 13, 2024
bded394
Remove jquery
yuvipanda Dec 13, 2024
352e4c1
Move chp to a dev dependency
yuvipanda Dec 13, 2024
42708a3
Upgrade version of xtermjs
yuvipanda Dec 13, 2024
ac62ba7
Remove unused 'clipboard' library
yuvipanda Dec 14, 2024
49d0f86
Write a clearer description for package.json
yuvipanda Dec 14, 2024
c089327
Mark the binderhub package itself as private
yuvipanda Dec 14, 2024
0fe56ae
Move react types to dev dependencies
yuvipanda Dec 14, 2024
73cc8f4
Upgrade version of react & related packages
yuvipanda Dec 14, 2024
dcd6bb1
Clarify Gist is GitHub Gist
yuvipanda Dec 14, 2024
9a73e00
Remove unused display_name property
yuvipanda Dec 14, 2024
4d670a5
Fix typo
yuvipanda Dec 14, 2024
b498b23
Fix typo
yuvipanda Dec 14, 2024
1927d34
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 14, 2024
b2dfd27
Fix off by 1 error with help messages
yuvipanda Dec 14, 2024
f379956
Remove debugging message
yuvipanda Dec 14, 2024
0fd5bb1
Add thicker borders to some controls
yuvipanda Dec 15, 2024
7276451
Make form background darker
yuvipanda Dec 15, 2024
3c895d9
Cleanup padding and rounded corners
yuvipanda Dec 15, 2024
2480656
Widen the form
yuvipanda Dec 16, 2024
b185b66
Clarify what binderhub supports for hydroshare
yuvipanda Dec 21, 2024
e117f39
Provide outline for buttons
yuvipanda Dec 21, 2024
7e0d5fb
Clarify what happens to the GA traitlets
yuvipanda Dec 21, 2024
e158610
Clarify what happens to the GA traitlets
yuvipanda Dec 21, 2024
acdc9fe
Turn tsc checking on (but don't enforce it)
yuvipanda Dec 21, 2024
54b6c19
Don't check js in our tsconfig
yuvipanda Dec 21, 2024
fbeb074
Revert adding noEmit
yuvipanda Dec 21, 2024
8679ba5
Make default opengraph title configurable
yuvipanda Dec 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove 'some errors disappear' error
I don't like it, because it doesn't tell you *what* errors
will be fixed by refreshing the page
  • Loading branch information
yuvipanda committed Dec 9, 2024
commit 3ee506989399ce1df29272f28745f690f5a4c635
4 changes: 1 addition & 3 deletions binderhub/static/js/components/ErrorPage.jsx
Original file line number Diff line number Diff line change
@@ -4,9 +4,7 @@ export function ErrorPage({ title, errorMessage }) {
<div className="container text-center jumbotron">
<h1>{title}</h1>

<p className="lead">
{errorMessage} Note: Some errors disappear by refreshing the page.
</p>
<p className="lead">{errorMessage}</p>
</div>
<div className="container">
<div className="row text-center">
4 changes: 0 additions & 4 deletions binderhub/static/js/pages/NotFoundPage.jsx
Original file line number Diff line number Diff line change
@@ -3,10 +3,6 @@ export function NotFoundPage() {
<>
<div className="container text-center jumbotron">
<h1>404: Not Found</h1>

<p className="lead">
Note: Some errors disappear by refreshing the page.
</p>
</div>
<div className="container">
<div className="row text-center">