-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add repo provider for MECA Bundles #1824
base: main
Are you sure you want to change the base?
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks sane. There are only some minor things to fix/update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the test MECA bundle, I think that the tests folder already contains mock data used for the tests. See the various .json
files the folder contains.
The URL origin must be included in the list of allowed_origins when that trait is set | ||
""" | ||
|
||
name = Unicode("MECA Bundle") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the test error, either name
should be only MECA
or launch.json
changed to contain MECA Bundle
.
fix typo Co-authored-by: Samuel Gaist <[email protected]>
26a5fff
to
1d08767
Compare
This PR adds a content provider for MECA Bundles.
MECA stands for Manuscript Exchange Common Approach, a NISO standard for transfer of manuscripts between manuscript systems.
This RepoProvider requires a parallel ContentProvider to be in place in
repo2docker
-- see this repo2docker PR for more background and detailsTODO