Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poll job status while waiting for single-user server to be reachable #254

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Dec 14, 2022

Fixes #253

Poll job status while waiting to get the port back from the single-server to catch any failure in the job before the server launches.

@welcome
Copy link

welcome bot commented Dec 14, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

ryanlovett added a commit to ryanlovett/batchspawner that referenced this pull request Apr 22, 2023
@ryanlovett
Copy link
Contributor

This worked for me when I intentionally added an exit 1 to our form's prologue field.

This was to simulate early failures that jupyterhub will otherwise miss. When it happens, the user cannot start the server because jupyterhub thinks it is already running. This might not be a problem for deployments with short timeouts -- the user can just wait. However we have long timeouts to match those for non-interactive activity. This will be very helpful for us.

@opoplawski
Copy link

This would be very helpful.

@consideRatio
Copy link
Member

This PR looks relevant even today, so I rebased this PR to resolve merge conflicts and get it to run against current tests. They are failing currently though =/

- add expected additional poll call during start
- add test for new behavior when poll stops early
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@consideRatio consideRatio merged commit 3a65827 into jupyterhub:main Mar 19, 2024
10 checks passed
Copy link

welcome bot commented Mar 19, 2024

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@lexming lexming deleted the deadstart branch March 19, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batch jobs that started but failed before launching the server leave the hub on unrecoverable state
5 participants