-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poll job status while waiting for single-user server to be reachable #254
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
This worked for me when I intentionally added an This was to simulate early failures that jupyterhub will otherwise miss. When it happens, the user cannot start the server because jupyterhub thinks it is already running. This might not be a problem for deployments with short timeouts -- the user can just wait. However we have long timeouts to match those for non-interactive activity. This will be very helpful for us. |
This would be very helpful. |
This PR looks relevant even today, so I rebased this PR to resolve merge conflicts and get it to run against current tests. They are failing currently though =/ |
- add expected additional poll call during start - add test for new behavior when poll stops early
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #253
Poll job status while waiting to get the port back from the single-server to catch any failure in the job before the server launches.