Create a new file from the Python API #678
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjxn-py
force-pushed
the
python-api-new-file
branch
from
c33176f to
580e480
Compare
Contributor
|
Preview PR at appsharing.space |
Contributor
|
Integration tests report: appsharing.space |
Member
|
As discussed in private, we should hold before merging this. The choice to create the file from Python is not correct since only the front-end will know the correct drive (in the sense of JupyterLab drive) where to create the file. |
Member
|
Creation of empty files is handled in JS by #680 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports geojupyter/jupytergis#402