Add direct dependency on ipykernel #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipywidgets 8.1.0 has been released, which includes the change at jupyter-widgets/ipywidgets#3811. With this change, ipykernel is no longer a dependnecy of ipywidgets, so jupyer-sphinx must now depend on ipykernel directly rather than assume it will be installed as a transitive dependency of ipywidgets. Without this change, jupyter-sphinx tests will fail CI. This has additionally led to CI failures in some packages that depend on jupyter-sphinx but not ipykernel.
|
You're editing the wrong file. The relevant dependency definition is in setup.py Lines 31 to 37 in 1bb7d91 |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Aug 23, 2023
https://build.opensuse.org/request/show/1105444 by user bnavigator + anag+factory - Add ipykernel to requirements * jupyter-sphinx-pr226-ipykernel.patch * gh#jupyter/jupyter-sphinx#226 - PEP517
Sorry, I erroneously assumed that this repository would obey DRY for this and therefore read |
|
note that it fixes #222 |
|
It would be nice to get this in - I now added a dependence to p.s. Thanks for a really nice extension to sphinx! |
garrison
added a commit
to Qiskit/qiskit-addon-cutting
that referenced
this pull request
May 21, 2024
This is no longer necessary now that a release has been made which includes jupyter/jupyter-sphinx#226.
garrison
added a commit
to Qiskit/qiskit-addon-cutting
that referenced
this pull request
May 22, 2024
This is no longer necessary now that a release has been made which includes jupyter/jupyter-sphinx#226.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipywidgets 8.1.0 has been released, which includes the change at jupyter-widgets/ipywidgets#3811. With this change, ipykernel is no longer a dependency of ipywidgets, so jupyer-sphinx must now depend on ipykernel directly rather than assume it will be installed as a transitive dependency of ipywidgets. Without this change, jupyter-sphinx tests will fail CI. This has additionally led to CI failures in some packages that depend on jupyter-sphinx but not ipykernel.
The minimum version chosen here is the same minimum version that was formerly specified by ipywidgets until jupyter-widgets/ipywidgets#3811.