Quote watch argument #125
Open
Quote watch argument #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried following the README: https://github.com/jupyter-widgets/widget-ts-cookiecutter/blob/94f9d384331150655c18a08d94307280c32adedd/README.md?plain=1#L94-L95 The `yarn run watch` failed for me, using node v16.17.1 and yarn 3.4.1: > No matches found: "watch:*" It works if I run `node_modules/.bin/npm-run-all -p 'watch:*'` in shell. It also works if I quote the argument. Looks to me like something is trying to expand that glob before invoking the binary. `strace` shows that the command doesn't get passed to `sh -c` as a whole. And `npm-run-all` isn't even executed so the error message is not coming from it. On the plus side, the fact that apparently these commands get executed by code inside node means portability should be no concern, and if single quotes work for me they hopefully work for everyone.
|
I second this - I used node v18.15.0 and yarn 3.5.1. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried following the README:
widget-ts-cookiecutter/README.md
Lines 94 to 95 in 94f9d38
The
yarn run watchfailed for me, using node v16.17.1 and yarn 3.4.1:It works if I run
node_modules/.bin/npm-run-all -p 'watch:*'in shell. It also works if I quote the argument. Looks to me like something is trying to expand that glob before invoking the binary.straceshows that the command doesn't get passed tosh -cas a whole. Andnpm-run-allisn't even executed so the error message is not coming from it. On the plus side, the fact that apparently these commands get executed by code inside node means portability should be no concern, and if single quotes work for me they hopefully work for everyone.