initial_attempt at resolving redraw for ImageOverlay #990
Conversation
|
|
||
| handle_message(content) { | ||
| if (content.msg == 'redraw') { | ||
| this.obj.redraw(); |
There was a problem hiding this comment.
There doesn't seem to be a redraw method on ImageOverlay according to the Leaflet docs https://leafletjs.com/reference.html#imageoverlay-setopacity
unless I missed it?
There was a problem hiding this comment.
Maybe you want to use setUrl instead, but there apparently no way of forcing the image to update if the url is the same.
According to this stackoverflow comment you can append the date to the url to force an update but I'm not sure we'd want to do this in ipyleaflet's codebase. Though nothing stops you from doing it in your notebook.
There was a problem hiding this comment.
Martin, thanks for the review.
For the leafletjs link to imageoverlay - I agree redraw is not a method on ImageOverlay, I will search through their github and see if that has been requested/makes sense as a feature request, if not I will file an issue.
The workarounds you suggested are ones I have employed and just seemed to add noise where noise was not needed - so I was trying to implement this redraw.
Since this would first depend on leaflet implementing something - should I just leave this pull request open as I work on that end? Not sure what the proper protocol is for a pull request.
There was a problem hiding this comment.
The workarounds you suggested are ones I have employed and just seemed to add noise where noise was not needed
Does the workaround work for the ImageOverlay then?
Since this would first depend on leaflet implementing something - should I just leave this pull request open as I work on that end?
Yes it's fine to keep this PR open for reference. I will turn it into draft.
There was a problem hiding this comment.
Does the workaround work for the
ImageOverlaythen?
Yes, I was originally just tearing down the layer and rebuilding as a workaround. Your suggestion of just resetting the url is much cleaner - thank you.
It would be nice to not have to get into url management with a new image for each zoom set so I still filed the request on leaflet as that would simplify end-user code.
Leaflet/Leaflet#8277
There was a problem hiding this comment.
One thing that would be nice would also to have the ImageOverlay work with an Image (from ipywidgets) widget
This is an attempt at resolving:
#989
I modeled the logic after:
#379
I was able to follow the steps outlined in:
https://ipyleaflet.readthedocs.io/en/latest/installation/index.html
I have the development environment up and running and the redraw method now appears on ImageOverlay, however when calling redraw that still does not resolve the issue.
I created the pull request to assist in the Issue discussion - if this was not the correct path to develop that conversation please let me know.