Conversation
Bumps [github.com/cert-manager/cert-manager](https://github.com/cert-manager/cert-manager) from 1.18.4 to 1.20.2. - [Release notes](https://github.com/cert-manager/cert-manager/releases) - [Changelog](https://github.com/cert-manager/cert-manager/blob/master/RELEASE.md) - [Commits](cert-manager/cert-manager@v1.18.4...v1.20.2) --- updated-dependencies: - dependency-name: github.com/cert-manager/cert-manager dependency-version: 1.20.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependabot PR Review SummaryChanges reviewed: Bumps CI Status: ❌ FAILINGMultiple CI jobs are failing:
|
| cert-manager 1.18.x | cert-manager 1.20.2 | |
|---|---|---|
| Go version | 1.24.0 | 1.25.0 |
| k8s.io/* deps | v0.32.0 | v0.35.2 |
| controller-runtime | v0.19.0 | v0.23.x |
The operator currently uses k8s.io v0.34.1, and the main controller uses k8s.io v0.33.0. Bumping to cert-manager 1.20.2 would force k8s.io to v0.35.2 — two versions ahead of the main controller — creating a severe version conflict across the project.
Root Cause of CI Failures
- Primary: Operator Dockerfile uses
ubi9/go-toolset:1.24.6withGOTOOLCHAIN=local. cert-manager 1.20.2 requires Go >= 1.25.0. - Secondary: Test infrastructure (
setup-envtest) pulls controller-runtime v0.23.3 requiring Go 1.25+.
Security Considerations
- cert-manager 1.18.6 (latest in 1.18.x series) already patches CVE-2025-68121 with zero dependency changes and no Go version requirement increase.
- No cert-manager-specific CVEs motivate the jump to 1.20.x.
Recommendation
Close this PR and bump to cert-manager 1.18.6 instead. This is a pure bugfix/security patch that:
- Fixes CVE-2025-68121
- Requires no Go version change
- Requires no k8s dependency version change
- Is a drop-in replacement for 1.18.4
I will push a commit with the 1.18.6 fix as an alternative.
cc @mangelajo @bzlotnik @kirkbrauer — This PR attempts to bump cert-manager from 1.18.4 to 1.20.2, which is effectively a k8s version bump (k8s.io v0.32→v0.35.2) and Go version bump (1.24→1.25). Recommend staying on 1.18.6 for now. If a cert-manager feature upgrade is eventually desired, 1.19.4 would be the best stepping stone (uses k8s.io v0.34.1, matching the operator's current deps).
cert-manager 1.20.2 requires Go 1.25.0 and k8s.io v0.35.2, which is incompatible with the project's current Go 1.24.x toolchain and k8s.io dependency versions. cert-manager 1.18.6 is a bugfix release that patches CVE-2025-68121 without requiring any Go or k8s version changes, making it a safe drop-in upgrade from 1.18.4. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
raballew
left a comment
There was a problem hiding this comment.
Safe patch-level bump (actual change is 1.18.4 -> 1.18.6, not 1.20.2 as the title suggests -- the commit history shows the downgrade from 1.20.2 was intentional due to Go 1.25 / k8s v0.35.2 incompatibility).
- Addresses CVE-2025-68121
- No transitive k8s.io dependency changes (go.mod hash identical between 1.18.4 and 1.18.6)
- No API breaking changes (stable v1 types: Issuer, ClusterIssuer, Certificate)
- Other go sub-projects (controller/go.mod, e2e/test/go.mod) do not depend on cert-manager -- no cross-module updates needed
- CI passing
🤖 Generated with Claude Code
Bumps github.com/cert-manager/cert-manager from 1.18.4 to 1.20.2.
Release notes
Sourced from github.com/cert-manager/cert-manager's releases.
... (truncated)
Commits
e5b7b18Merge pull request #8704 from erikgb/1-20-fix-vuln-go-depse7ec855Merge pull request #8703 from erikgb/1-20-bump-go-base-imagescd96b95[release-1.20] Bump go dependencies with reported vulnerabilitiesa1b6f11[release-1.20] Bump go to 1.26.2 and bump base images6dee676Merge pull request #8665 from cert-manager-bot/cherry-pick-8664-to-release-1.209ccf555Fix indentation in webhook-deployment when both webhook.volumes and webhook.c...dc96863Merge pull request #8658 from cert-manager-bot/cherry-pick-8619-to-release-1.207e66079removing duplicate parentRefs75f90e4Merge pull request #8657 from erikgb/fix-grpc-vulnf27364cUpdate module google.golang.org/grpc to v1.79.3 [security] (release-1.20)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)