fix: reset retry counter after receiving data in exporter reconnect#396
Open
raballew wants to merge 1 commit intojumpstarter-dev:mainfrom
Open
fix: reset retry counter after receiving data in exporter reconnect#396raballew wants to merge 1 commit intojumpstarter-dev:mainfrom
raballew wants to merge 1 commit intojumpstarter-dev:mainfrom
Conversation
The retry counter in _retry_stream was never reset after a successful reconnection because the reset logic was in the try/else clause, which only runs when the async-for loop exits cleanly. Since gRPC streams always end via exception, the else clause never executed, causing the exporter to eventually fail after accumulated disconnects. Adds a received_data flag that tracks whether any item was received during the current connection attempt, and resets retries_left in the except block when data was received. Closes jumpstarter-dev#38 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
❌ Deploy Preview for jumpstarter-docs failed. Why did it fail? →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try/elseblock that only runs when the async-for loop exits cleanly -- gRPC streams always end via exception, so it never firedTest plan
Closes #38
🤖 Generated with Claude Code