Skip to content

ridesx: support OCI flashing #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mangelajo merged 4 commits into from
Feb 9, 2026
Merged

ridesx: support OCI flashing #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2e49ea
common: add shared FLS binary download utilities
bennyz Feb 3, 2026
1012c47
ridesx: support OCI flashing
bennyz Feb 3, 2026
81a3638
ridesx: add tests for fls integration
bennyz Feb 3, 2026
63b7910
add support for registry creds
bennyz Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion python/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,19 @@ RUN dnf install -y make git && \
COPY --from=uv /uv /uvx /bin/

FROM fedora:43 AS product
RUN dnf install -y python3 ustreamer libusb1 android-tools python3-libgpiod && \
RUN dnf install -y python3 ustreamer libusb1 android-tools python3-libgpiod curl && \
dnf clean all && \
rm -rf /var/cache/dnf
COPY --from=ghcr.io/astral-sh/uv:latest /uv /uvx /bin/

ARG FLS_VERSION=0.1.9
RUN ARCH=$(uname -m) && \
URL="https://github.com/jumpstarter-dev/fls/releases/download/${FLS_VERSION}/fls-${ARCH}-linux" && \
TEMP_FILE="/tmp/fls-${ARCH}-linux.tmp" && \
curl -fsSL "${URL}" -o "${TEMP_FILE}" && \
mv "${TEMP_FILE}" /usr/local/bin/fls && \
chmod +x /usr/local/bin/fls

FROM builder AS wheels
ADD . /src
RUN make -C /src/python build
Expand Down
5 changes: 3 additions & 2 deletions python/packages/jumpstarter-driver-flashers/jumpstarter_driver_flashers/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

from jumpstarter.client.decorators import driver_click_group
from jumpstarter.common.exceptions import ArgumentError, JumpstarterException
from jumpstarter.common.fls import get_fls_github_url


class FlashError(JumpstarterException):
Expand Down Expand Up @@ -533,8 +534,8 @@ def _flash_with_fls(
self._download_fls_binary(console, prompt, fls_binary_url, f"Failed to download FLS from {fls_binary_url}")
elif fls_version != "":
self.logger.info(f"Downloading FLS version {fls_version} from GitHub releases")
# Download fls binary to the target device (until it is available on the target device)
fls_url = f"https://github.com/jumpstarter-dev/fls/releases/download/{fls_version}/fls-aarch64-linux"
# Download fls binary to the target device (always aarch64 for target devices)
fls_url = get_fls_github_url(fls_version, arch="aarch64")
self._download_fls_binary(console, prompt, fls_url, f"Failed to download FLS from {fls_url}")
Copy link
Copy Markdown
Member

@mangelajo mangelajo Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we reorganize this so that instead of always downloading, we embed a version in the general jumpstarter Dockerfile ?

This can also be a security issue, I would add a flag in the driver side + config, that disabled by default fls download from any random URL. This is an attack vector: just pass the URL to a trojan that will run on a container with privileges :-)

On the DUT it is a bit different because it will be powered off and it's volatile/will be reset.

Copy link
Copy Markdown
Member

@mangelajo mangelajo Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that still having the ability to enable it makes it easier for administrators to try out new fls versions, but should be disabled by default and encouraged not to allow such thing with a huge warning :D

Copy link
Copy Markdown
Member Author

@bennyz bennyz Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah yeah, i had a note to remove this when i'm done, it was easier for me than doing copies into the live exporter container each time 😅

Copy link
Copy Markdown
Member Author

@bennyz bennyz Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but yes, we can have an exporter side flag for admins

Copy link
Copy Markdown
Member Author

@bennyz bennyz Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added:

    config:
      log_level: "DEBUG"
      fls_allow_custom_binaries: true
      fls_custom_binary_url: "https://github.com/bennyz/fls/releases/download/ridesx/fls"

we'll keep this between us 😅

Copy link
Copy Markdown
Member

@mangelajo mangelajo Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the url is exporter set, I think it's perfectly fine :D


# Flash the image
Expand Down
Loading
Loading