don't ask the "unsafe" question in noninteractive login by michalskrivanek · Pull Request #699 · jumpstarter-dev/jumpstarter-python

michalskrivanek · 2025-10-09T06:33:57Z

caller has to use --unsafe or --allow

Summary by CodeRabbit

Bug Fixes
- Non-interactive mode now defaults to safe behavior (unsafe disabled) and skips the interactive prompt to avoid blocking automation.
- Error message in non-interactive contexts updated to clearly require explicit flags when no allowed driver packages are provided.
- Interactive workflows and prompts remain unchanged.

coderabbitai · 2025-10-09T06:34:21Z

Walkthrough

In the CLI login flow, non-interactive mode now defaults unsafe=False (skipping the unsafe-import prompt). The prompt for allowed driver packages is only shown in interactive mode. In non-interactive mode, if no allow list is provided the error now states: "--allow TEXT or --unsafe is required in non-interactive mode."

Changes

Cohort / File(s)	Summary of changes
CLI Login Flow `packages/jumpstarter-cli/jumpstarter_cli/login.py`	Default `unsafe=False` in non-interactive mode (skip unsafe prompt); only prompt for allowed driver packages in interactive mode; updated non-interactive error message to: "--allow TEXT or --unsafe is required in non-interactive mode."

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant CLI as CLI Login
  participant Prompt as Prompt Handler
  participant Config as Config/Validator

  rect rgb(240,248,255)
  note over CLI: Interactive mode (unchanged)
  User->>CLI: login
  CLI->>Prompt: Ask "Allow unsafe driver client imports?"
  Prompt-->>CLI: User choice (allow/deny)
  CLI->>Config: Apply choice and validate allow list
  Config-->>CLI: Result (ok/error)
  CLI-->>User: Outcome
  end

  rect rgb(245,245,245)
  note over CLI: Non-interactive mode (changed)
  User->>CLI: login --non-interactive
  CLI->>CLI: Set unsafe = False (default)
  CLI->>Prompt: Skip prompt
  alt allow list provided
    CLI->>Config: Validate allow list
    Config-->>CLI: Result (ok/error)
    CLI-->>User: Outcome
  else no allow list
    CLI-->>User: Error: "--allow TEXT or --unsafe is required in non-interactive mode."
  end
  end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I’m a rabbit in a quiet shell,
I skip the question, all is well.
Safe by default, I hop and check,
If lists are missing — pause, reflect.
A tiny tweak, a tidy trail. 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly captures the primary change of the pull request by indicating that the CLI will no longer prompt for the "unsafe" option in noninteractive mode, which directly reflects the updated default behavior and error messaging in login.py.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

netlify · 2025-10-09T06:35:07Z

✅ Deploy Preview for jumpstarter-docs ready!

Name	Link
🔨 Latest commit	`df57e6f`
🔍 Latest deploy log	https://app.netlify.com/projects/jumpstarter-docs/deploys/68e759a93ae4e5000896f3d5
😎 Deploy Preview	https://deploy-preview-699--jumpstarter-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/jumpstarter-cli/jumpstarter_cli/login.py (1)
87-92: Consider clarifying "safe mode" in the error message.

The logic is correct, and changing the error message from "non-interactive mode" to "safe mode" better describes the actual constraint. However, "safe mode" might not be immediately clear to users.

Consider enhancing the error message for clarity:
                 if nointeractive:
-                    raise click.UsageError("Allowed driver packages are required in safe mode.")
+                    raise click.UsageError("Allowed driver packages are required in safe mode. Use --allow or --unsafe.")

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6373b76 and 809cbb3.

📒 Files selected for processing (1)

packages/jumpstarter-cli/jumpstarter_cli/login.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

GitHub Check: Redirect rules - jumpstarter-docs
GitHub Check: Header rules - jumpstarter-docs
GitHub Check: Pages changed - jumpstarter-docs
GitHub Check: build
GitHub Check: pytest-matrix (macos-15, 3.11)
GitHub Check: pytest-matrix (ubuntu-24.04, 3.13)
GitHub Check: pytest-matrix (macos-15, 3.13)
GitHub Check: pytest-matrix (ubuntu-24.04, 3.12)
GitHub Check: pytest-matrix (macos-15, 3.12)
GitHub Check: pytest-matrix (ubuntu-24.04, 3.11)
GitHub Check: e2e

🔇 Additional comments (1)

packages/jumpstarter-cli/jumpstarter_cli/login.py (1)

86-86: LGTM! Safe default for non-interactive mode.

Defaulting unsafe to False in non-interactive mode is the correct security posture, requiring callers to explicitly opt in via --unsafe flag when needed.

caller has to use --unsafe or --allow

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 809cbb3 and df57e6f.

📒 Files selected for processing (1)

packages/jumpstarter-cli/jumpstarter_cli/login.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)

GitHub Check: Redirect rules - jumpstarter-docs
GitHub Check: Header rules - jumpstarter-docs
GitHub Check: Pages changed - jumpstarter-docs
GitHub Check: pytest-matrix (ubuntu-24.04, 3.12)
GitHub Check: pytest-matrix (ubuntu-24.04, 3.11)
GitHub Check: pytest-matrix (macos-15, 3.12)
GitHub Check: pytest-matrix (macos-15, 3.11)
GitHub Check: pytest-matrix (ubuntu-24.04, 3.13)
GitHub Check: pytest-matrix (macos-15, 3.13)
GitHub Check: e2e

🔇 Additional comments (1)

packages/jumpstarter-cli/jumpstarter_cli/login.py (1)

86-86: LGTM: Correct default behavior in non-interactive mode.

The logic correctly defaults unsafe to False in non-interactive mode, avoiding the interactive prompt. This is the secure choice and aligns with the PR objective.

packages/jumpstarter-cli/jumpstarter_cli/login.py

jumpstarter-backport-bot · 2025-10-09T11:21:35Z

Successfully created backport PR for release-0.7:

[Backport release-0.7] don't ask the "unsafe" question in noninteractive login #702

coderabbitai bot reviewed Oct 9, 2025

View reviewed changes

don't ask the "unsafe" question in noninteractive login

df57e6f

caller has to use --unsafe or --allow

michalskrivanek force-pushed the unsafe branch from 809cbb3 to df57e6f Compare October 9, 2025 06:43

coderabbitai bot reviewed Oct 9, 2025

View reviewed changes

packages/jumpstarter-cli/jumpstarter_cli/login.py Show resolved Hide resolved

mangelajo approved these changes Oct 9, 2025

View reviewed changes

mangelajo enabled auto-merge October 9, 2025 06:54

mangelajo merged commit 41d932b into jumpstarter-dev:main Oct 9, 2025
18 checks passed

michalskrivanek deleted the unsafe branch October 9, 2025 06:56

mangelajo added the backport release-0.7 label Oct 9, 2025

jumpstarter-backport-bot bot mentioned this pull request Oct 9, 2025

[Backport release-0.7] don't ask the "unsafe" question in noninteractive login #702

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

don't ask the "unsafe" question in noninteractive login#699

don't ask the "unsafe" question in noninteractive login#699
mangelajo merged 1 commit intojumpstarter-dev:mainfrom
michalskrivanek:unsafe

michalskrivanek commented Oct 9, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

netlify bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

jumpstarter-backport-bot bot commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

michalskrivanek commented Oct 9, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

netlify bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for jumpstarter-docs ready!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jumpstarter-backport-bot bot commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

michalskrivanek commented Oct 9, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 9, 2025 •

edited

Loading

netlify bot commented Oct 9, 2025 •

edited

Loading