Skip to content

Clarify deletion of variables #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 17, 2019
Merged

Clarify deletion of variables #793

merged 12 commits into from
Jul 17, 2019

Conversation

blegat
Copy link
Member

@blegat blegat commented Jul 14, 2019

Extracted from #759. It also refactors implementation of names to share more code with UniversalFallback that will also be used by bridges in #759

Closes #511

@blegat blegat added this to the v0.9 milestone Jul 14, 2019
Copy link
Member

@mlubin mlubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed only the docs, haven't looked at the code yet.

@codecov-io
Copy link

codecov-io commented Jul 14, 2019

Codecov Report

Merging #793 into master will increase coverage by 0.06%.
The diff coverage is 96.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
+ Coverage   93.99%   94.06%   +0.06%     
==========================================
  Files          59       59              
  Lines        6542     6702     +160     
==========================================
+ Hits         6149     6304     +155     
- Misses        393      398       +5
Impacted Files Coverage Δ
src/Utilities/sets.jl 100% <ø> (ø) ⬆️
src/indextypes.jl 85.71% <ø> (ø) ⬆️
src/Test/modellike.jl 99.22% <100%> (+0.17%) ⬆️
src/Utilities/results.jl 80.66% <100%> (ø) ⬆️
src/Utilities/functions.jl 95.08% <100%> (ø) ⬆️
src/Bridges/Constraint/slack.jl 93.54% <100%> (ø) ⬆️
src/sets.jl 89.65% <33.33%> (-3.08%) ⬇️
src/Utilities/mockoptimizer.jl 90.14% <85.71%> (-0.16%) ⬇️
src/Utilities/universalfallback.jl 97.29% <96%> (-0.25%) ⬇️
src/Utilities/model.jl 93.22% <98.27%> (+1.75%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2bb7bc...b54ae5d. Read the comment docs.

@blegat blegat merged commit f5a1036 into master Jul 17, 2019
@odow odow deleted the bl/delete_vector_of_variables branch August 29, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

What happens when deleting a variable in a constraint?
3 participants