Address TODOs #786
Merged
Address TODOs #786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlubin
reviewed
Jul 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #786 +/- ##
==========================================
+ Coverage 93.92% 93.94% +0.01%
==========================================
Files 59 59
Lines 6540 6573 +33
==========================================
+ Hits 6143 6175 +32
- Misses 397 398 +1
Continue to review full report at Codecov.
|
mlubin
reviewed
Jul 14, 2019
mlubin
reviewed
Jul 15, 2019
mlubin
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably transition the knapsack example to a doctest with
MockOptimizer. More doctests are added in #759.Closes #780