Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Utilities] add PenaltyRelaxation #1995
[Utilities] add PenaltyRelaxation #1995
Changes from 18 commits
a66c546
12e970d
b963d18
f006454
95012eb
405692c
c8719ee
c9cd475
5a4a06e
7c7470e
56ae024
93eca46
e0d064f
2bfb486
a5bbee7
c1ce388
594bf94
2a0fece
1981e0a
a2d19fe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is inconsistent, if a modification is not supported, an error should be thrown instead. Is that useful for
VariableIndex
only ? Then we can check whether it isVariableIndex
before callingmodify
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's for any set that isn't supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We either need
supports
or we need this fallback.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the method below defined for any
AbstractScalarSet
?So this is in case an MOI extension defines another type of
AbstractScalarFunction
?We could extend the definition of
supports
but then we need to addsupports
methods for solvers.Another option is to add a keyword to the
modify
that is model-wise likeignore_unsupported
.If this is false, we just modify and let the error propagate.
Otherwise, we use a
try
-catch
and handleModifyConstraintNotAllowed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the
try-catch
.