Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs and tests for infeasibility certificates #1660

Merged
merged 11 commits into from
Nov 20, 2021
Merged

Conversation

odow
Copy link
Member

@odow odow commented Nov 16, 2021

This PR adds documentation and tests for primal and dual infeasibility certificates.

Preview link
https://jump.dev/MathOptInterface.jl/previews/PR1660/background/infeasibility_certificates/

Closes #433.
Closes #1201

@odow odow added the Type: Documentation This issue requires changes to the documentation label Nov 16, 2021
@odow odow requested a review from blegat November 16, 2021 03:29
@blegat
Copy link
Member

blegat commented Nov 16, 2021

Is this tested ?

@odow
Copy link
Member Author

odow commented Nov 16, 2021

No tests yet. I started, but then I opened #1661. I'll create a new set of tests, rather than modifying the existing ones. I think some of the ObjectiveValue and DualObjectiveValue tests might fail.

@odow odow force-pushed the od/infeas-certificates branch from 8c14dbe to d669c0e Compare November 16, 2021 21:18
Add tests for dual infeasibility cert
@odow odow force-pushed the od/infeas-certificates branch from b8df0b5 to b8bc613 Compare November 16, 2021 22:48
@odow
Copy link
Member Author

odow commented Nov 17, 2021

Looked at updating GLPK and Gurobi. They're actually pretty easy to update.

Although I got bit bad (again) by this bug in Gurobi 9.1: jump-dev/Gurobi.jl#363 (comment). Sign errors are the worst to track down.

@odow odow changed the title WIP: [docs] add background on infeasibility certificates Add docs and tests for infeasibility certificates Nov 17, 2021
@odow
Copy link
Member Author

odow commented Nov 17, 2021

SCS and GLPK are passing these tests on their respective PRs, so I think we're good to go on my end.

src/Utilities/results.jl Outdated Show resolved Hide resolved
src/Utilities/results.jl Outdated Show resolved Hide resolved
@odow odow requested a review from blegat November 19, 2021 00:57
@odow odow merged commit c34a594 into master Nov 20, 2021
@odow odow deleted the od/infeas-certificates branch November 20, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation This issue requires changes to the documentation
2 participants