[breaking] s/DataType/Type #1501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #783
We should use
Type
instead ofDataType
.The issue is that
DataType
is a concrete type of Type (confusing right) that causes the compiler problems (to quote Jeff "this sort of stuff drives the compiler crazy" and "if you're doing that, please stop").I tried a few other things, such as
Tuple{Type{<:MOI.AbstractFunction},Type{<:MOI.AbstractSet}}
but couldn't get them to work. It seems for a lot of these things, we want simpler type signatures with some run-time asserts to reduce our latency. These paths aren't hot and time-critical.