-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update variables.md explanation of parameters #3916
base: master
Are you sure you want to change the base?
Conversation
I was confused by this example at multiple levels. I didn't understand what "Parameters set" means, is there a whole set of parameters somewhere? I didn't understand `Parameter(i)` because `i` looks like an index, not a value. I didn't get how there can be `x in SecondOrderCone` and `x in Parameter(i)`, same syntax but seemingly different concepts. The values are eventually revealed later on in example, but even then I was confused. This change is to try to be more explicit about what's going on, in case others are as obtuse as I am. I hope something like this will be clearer.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3916 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 43 43
Lines 6059 6059
=======================================
Hits 6034 6034
Misses 25 25 ☔ View full report in Codecov by Sentry. |
The build failed because it failed a test on |
Hi @artkuo, thanks for opening the PR! Don't worry about the failure. It is my fault: #3917 To answer some of your questions:
JuMP uses "set" to mean the domains that constraint functions belong to. If you have time, you might want to read https://arxiv.org/abs/2002.03447. Or you can take a look at https://jump.dev/JuMP.jl/stable/moi/manual/standard_form/ So
https://jump.dev/JuMP.jl/stable/api/JuMP/#Parameter which is really just a synonym for: https://jump.dev/JuMP.jl/stable/moi/reference/standard_form/#MathOptInterface.Parameter
It's a value 😄 |
I made a change. Is that better? |
Yes, that looks great! Sorry about my questions, they were meant to be rhetorical but were eventually resolved. I should have put that under "This change is..." I think your revision is very nice, thanks. The |
I'm was confused, I clicked "close with comment" thinking your revision would be merged. But it looks like that just killed the pull request. I'm leaving open in case you need to see that your revision still needs to be merged. Please close this if and when appropriate. |
I have the power to edit your PR directly 😄 When I merge it, it'll attribute you as the author. |
I was confused by this example at multiple levels. I didn't understand what "Parameters set" means, is there a whole set of parameters somewhere? I didn't understand
Parameter(i)
becausei
looks like an index, not a value. I didn't get how there can bex in SecondOrderCone
andx in Parameter(i)
, same syntax but seemingly different concepts. The values are eventually revealed later on in example, but even then I was confused.This change is to try to be more explicit about what's going on, in case others are as obtuse as I am. I hope something like this will be clearer.