Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the objective constant directly to the solver instead of caching it #64

Merged
merged 2 commits into from
Aug 18, 2018

Conversation

rdeits
Copy link
Collaborator

@rdeits rdeits commented Aug 17, 2018

@rdeits
Copy link
Collaborator Author

rdeits commented Aug 17, 2018

When this is merged, would you be willing to tag a new release, since master now supports LQOI v0.3/MOI v0.5?

@odow
Copy link
Member

odow commented Aug 17, 2018

Yip sounds good.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling f1a4904 on rdeits:rd/constant-objective into 66867a0 on JuliaOpt:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling f1a4904 on rdeits:rd/constant-objective into 66867a0 on JuliaOpt:master.

@rdeits
Copy link
Collaborator Author

rdeits commented Aug 18, 2018

It looks like there's a consistent segfault while precompiling on 32-bit Julia v0.7 and above on windows. Is that a known issue?

@odow
Copy link
Member

odow commented Aug 18, 2018

Yes, see #61 (comment)

I posted an issue on discourse but didn't get any hits. Shall I open a Julia issue?

@rdeits
Copy link
Collaborator Author

rdeits commented Aug 18, 2018

Yeah, I'd open a Julia issue. If it's reproducible it should get fixed pretty quickly.

@rdeits
Copy link
Collaborator Author

rdeits commented Aug 18, 2018

ok, all green (except the known appveyor issues)

@mlubin mlubin merged commit 9c375f1 into jump-dev:master Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants