Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binary to 2.10.5 #160

Merged
merged 4 commits into from
Mar 15, 2021
Merged

Update binary to 2.10.5 #160

merged 4 commits into from
Mar 15, 2021

Conversation

odow
Copy link
Member

@odow odow commented Mar 11, 2021

Upstream changes involved removing this patch:
JuliaPackaging/Yggdrasil@adaac1c
We also had some issues tagging a release of Cbc_jll:
JuliaRegistries/General#31558

I'm marking this as a breaking release so there is a path for users to stay on 2.10.3 if something fails.

In particular, the patch we had masked SOS failures like #151.

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #160 (db7614b) into master (43eb1cc) will decrease coverage by 1.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   54.16%   53.14%   -1.03%     
==========================================
  Files           3        3              
  Lines         480      525      +45     
==========================================
+ Hits          260      279      +19     
- Misses        220      246      +26     
Impacted Files Coverage Δ
src/Cbc.jl 50.00% <ø> (ø)
src/MOI_wrapper/MOI_wrapper.jl 79.93% <83.33%> (-6.10%) ⬇️
src/gen/libcbc_api.jl 12.56% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43eb1cc...db7614b. Read the comment docs.

@odow
Copy link
Member Author

odow commented Mar 11, 2021

@giordano I guess you're like me, on mac? That would explain why it worked for us...

@giordano
Copy link

No, I'm on Linux

@odow odow closed this Mar 15, 2021
@odow odow reopened this Mar 15, 2021
@odow odow merged commit 47c3a82 into master Mar 15, 2021
@odow odow deleted the od/2.10.5 branch March 15, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants