Enhance Chromaprint Accuracy Using Chapters #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Honestly, I haven't had to use chromaprint at all and still get decent results from chapters alone, so it seems like chromaprint is more a fallback these days. This would solve the one lingering issue of trying to identify the right one if you can't match a name. |
|
This likely needs extended testing to ensure that everything works correctly and that no actual episode content is accidentally cut off. |
|
hmm not sure how to test this... maybe we should add a unit test? |
jumoog
approved these changes
Aug 14, 2024
|
Updates cached file suffix to |
Not a bad idea, but it will redo the |
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.