Pairwise dragging #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienvincent
force-pushed
the
jv/pairwise-dragging
branch
4 times, most recently
from
6bf71ba
to
090f202
Compare
This adds two new APIs - `drag_pair_forwards` and its companion `drag_pair_backwards` which allow dragging 'pairs' of elements within a form. An easy example is the key-value pairs within a map which typically are meant to stay together when reordering. This can, however, be used for any form. This means if you have some vector containing logical pairs (because of the actual semantics of your code) you can use a dedicated keybinding to drag them around together. This change also introduces a new config option at: `dragging.auto_drag_pairs = true|false` which will alter the behaviour of the existing `drag_element_forwards` and `drag_element_backwards` APIs in order to try infer whether they are contained within a node that is made up of pairs. For example if this setting is `true` and a `drag_element_forwards` is used on the keys of a map then they will be dragged pairwise. This new config option defaults to `true` under the assumption that this is generally the desired behaviour.
julienvincent
force-pushed
the
jv/pairwise-dragging
branch
from
090f202
to
cf1b77f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new APIs -
drag_pair_forwardsand its companiondrag_pair_backwardswhich allow dragging 'pairs' of elements within a form.An easy example is the key-value pairs within a map which typically are meant to stay together when reordering.
This can, however, be used for any form. This means if you have some vector containing logical pairs (because of the actual semantics of your code) you can use a dedicated keybinding to drag them around together.
This change also introduces a new config option at:
dragging.auto_drag_pairs = true|falsewhich will alter the behaviour of the existing
drag_element_forwardsanddrag_element_backwardsAPIs in order to try infer whether they are contained within a node that is made up of pairs.For example if this setting is
trueand adrag_element_forwardsis used on the keys of a map then they will be dragged pairwise.This new config option defaults to
trueunder the assumption that this is generally the desired behaviour.