Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #42: Exclusive motion support #46

Merged
merged 6 commits into from
Oct 26, 2023
Merged

fixes #42: Exclusive motion support #46

merged 6 commits into from
Oct 26, 2023

Conversation

armed
Copy link
Collaborator

@armed armed commented Oct 16, 2023 •
edited
Loading

  • move_to_next_element_head now becomes exclusive when operator mode is active.
  • also it acts as move_to_next_element_tail when there is no next element available (only in non reversed mode), same logic as native w motion.

julienvincent
julienvincent reviewed Oct 22, 2023
View reviewed changes
Copy link
Owner

@julienvincent julienvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for when in operator-pending mode? Otherwise looks good

@armed
Copy link
Collaborator Author

armed commented Oct 24, 2023

Can we add a test for when in operator-pending mode? Otherwise looks good

@julienvincent good catch, done

@julienvincent julienvincent merged commit 5818754 into master Oct 26, 2023
2 checks passed
@julienvincent julienvincent deleted the exclusive_motion_support branch October 26, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienvincent julienvincent julienvincent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armed @julienvincent