Replace operator keymap field with smarter funcs
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the E/B motions are configured with `operator = true` which additionally adds the `o` mode keymap with the fn wrapped in `normal! v` to allow it to function in operator-pending mode. This moves responsibility into the keymap setup phase instead of the function handling the action, and in the current implementation won't work in visual mode operator-pending states. This commit shifts the responsibility to the motions API by allowing them to detect the current mode and conditionally set `normal! v`.
When switching to visual mode from operator-pending the value of the internal `vim.v.count1` var is reset to 1. This commit stores the value before switching to `normal! v`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the E/B motions are configured with
operator = truewhich additionally adds theomode keymap with the fn wrapped innormal! vto allow it to function in operator-pending mode.This moves responsibility into the keymap setup phase instead of the function handling the action, and in the current implementation won't work in visual mode operator-pending states.
This commit shifts the responsibility to the motions API by allowing them to detect the current mode and conditionally set
normal! v.