-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip(deploy): Sample docker-compose files for different scenarios #552
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 25fb125 in 45 seconds
More details
- Looked at
1132
lines of code in9
files - Skipped
0
files when reviewing. - Skipped posting
7
drafted comments based on config settings.
1. deploy/docker-compose.multi-tenant-cpu-selfhosted.yml:73
- Draft comment:
Thedepends_on
conditionservice_started
is deprecated. Consider usingservice_healthy
for better reliability. This is applicable in other files as well. - Reason this comment was not posted:
Marked as duplicate.
2. deploy/docker-compose.multi-tenant-gpu-managed.yml:78
- Draft comment:
Thedepends_on
conditionservice_started
is deprecated. Consider usingservice_healthy
for better reliability. This is applicable in other files as well. - Reason this comment was not posted:
Marked as duplicate.
3. deploy/docker-compose.multi-tenant-gpu-selfhosted.yml:78
- Draft comment:
Thedepends_on
conditionservice_started
is deprecated. Consider usingservice_healthy
for better reliability. This is applicable in other files as well. - Reason this comment was not posted:
Marked as duplicate.
4. deploy/docker-compose.single-tenant-cpu-managed.yml:71
- Draft comment:
Thedepends_on
conditionservice_started
is deprecated. Consider usingservice_healthy
for better reliability. This is applicable in other files as well. - Reason this comment was not posted:
Marked as duplicate.
5. deploy/docker-compose.single-tenant-cpu-selfhosted.yml:71
- Draft comment:
Thedepends_on
conditionservice_started
is deprecated. Consider usingservice_healthy
for better reliability. This is applicable in other files as well. - Reason this comment was not posted:
Marked as duplicate.
6. deploy/docker-compose.single-tenant-gpu-managed.yml:76
- Draft comment:
Thedepends_on
conditionservice_started
is deprecated. Consider usingservice_healthy
for better reliability. This is applicable in other files as well. - Reason this comment was not posted:
Marked as duplicate.
7. deploy/docker-compose.single-tenant-gpu-selfhosted.yml:76
- Draft comment:
Thedepends_on
conditionservice_started
is deprecated. Consider usingservice_healthy
for better reliability. This is applicable in other files as well. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_sOw0Wshx7XRCu8wu
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
- "8080:8080" | ||
depends_on: | ||
memory-store: | ||
condition: service_started |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The depends_on
condition service_started
is deprecated. Consider using service_healthy
for better reliability. This is applicable in other files as well.
Signed-off-by: Diwank Singh Tomer [email protected]
Important
Adds Docker Compose files for various Julep deployment scenarios, including single/multi-tenant modes with CPU/GPU embeddings and managed/self-hosted databases, with detailed documentation.
docker-compose.single-tenant-cpu-managed.yml
,docker-compose.multi-tenant-cpu-managed.yml
, anddocker-compose.single-tenant-gpu-managed.yml
for managed database deployments.docker-compose.single-tenant-cpu-selfhosted.yml
,docker-compose.multi-tenant-cpu-selfhosted.yml
, anddocker-compose.single-tenant-gpu-selfhosted.yml
for self-hosted database deployments.docker-compose.multi-tenant-gpu-managed.yml
anddocker-compose.multi-tenant-gpu-selfhosted.yml
for GPU-based deployments.README.md
indeploy
directory detailing each Docker Compose configuration, including use cases and deployment requirements.This description was created by for 25fb125. It will automatically update as commits are pushed.