Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip(deploy): Sample docker-compose files for different scenarios #552

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Oct 2, 2024

Signed-off-by: Diwank Singh Tomer [email protected]


Important

Adds Docker Compose files for various Julep deployment scenarios, including single/multi-tenant modes with CPU/GPU embeddings and managed/self-hosted databases, with detailed documentation.

  • New Files:
    • Adds docker-compose.single-tenant-cpu-managed.yml, docker-compose.multi-tenant-cpu-managed.yml, and docker-compose.single-tenant-gpu-managed.yml for managed database deployments.
    • Adds docker-compose.single-tenant-cpu-selfhosted.yml, docker-compose.multi-tenant-cpu-selfhosted.yml, and docker-compose.single-tenant-gpu-selfhosted.yml for self-hosted database deployments.
    • Adds docker-compose.multi-tenant-gpu-managed.yml and docker-compose.multi-tenant-gpu-selfhosted.yml for GPU-based deployments.
  • Documentation:
    • New README.md in deploy directory detailing each Docker Compose configuration, including use cases and deployment requirements.

This description was created by Ellipsis for 25fb125. It will automatically update as commits are pushed.

@creatorrr creatorrr marked this pull request as ready for review October 14, 2024 11:09
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 25fb125 in 45 seconds

More details
  • Looked at 1132 lines of code in 9 files
  • Skipped 0 files when reviewing.
  • Skipped posting 7 drafted comments based on config settings.
1. deploy/docker-compose.multi-tenant-cpu-selfhosted.yml:73
  • Draft comment:
    The depends_on condition service_started is deprecated. Consider using service_healthy for better reliability. This is applicable in other files as well.
  • Reason this comment was not posted:
    Marked as duplicate.
2. deploy/docker-compose.multi-tenant-gpu-managed.yml:78
  • Draft comment:
    The depends_on condition service_started is deprecated. Consider using service_healthy for better reliability. This is applicable in other files as well.
  • Reason this comment was not posted:
    Marked as duplicate.
3. deploy/docker-compose.multi-tenant-gpu-selfhosted.yml:78
  • Draft comment:
    The depends_on condition service_started is deprecated. Consider using service_healthy for better reliability. This is applicable in other files as well.
  • Reason this comment was not posted:
    Marked as duplicate.
4. deploy/docker-compose.single-tenant-cpu-managed.yml:71
  • Draft comment:
    The depends_on condition service_started is deprecated. Consider using service_healthy for better reliability. This is applicable in other files as well.
  • Reason this comment was not posted:
    Marked as duplicate.
5. deploy/docker-compose.single-tenant-cpu-selfhosted.yml:71
  • Draft comment:
    The depends_on condition service_started is deprecated. Consider using service_healthy for better reliability. This is applicable in other files as well.
  • Reason this comment was not posted:
    Marked as duplicate.
6. deploy/docker-compose.single-tenant-gpu-managed.yml:76
  • Draft comment:
    The depends_on condition service_started is deprecated. Consider using service_healthy for better reliability. This is applicable in other files as well.
  • Reason this comment was not posted:
    Marked as duplicate.
7. deploy/docker-compose.single-tenant-gpu-selfhosted.yml:76
  • Draft comment:
    The depends_on condition service_started is deprecated. Consider using service_healthy for better reliability. This is applicable in other files as well.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_sOw0Wshx7XRCu8wu


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

- "8080:8080"
depends_on:
memory-store:
condition: service_started
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The depends_on condition service_started is deprecated. Consider using service_healthy for better reliability. This is applicable in other files as well.

@creatorrr creatorrr marked this pull request as draft October 16, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant