Move test utils into a separate module #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-w-shaw
approved these changes
Jul 12, 2023
|
/merge |
jujubot
added a commit
that referenced
this pull request
Jul 20, 2023
#920 ## What's Changed * Update readme and add some docstrings for functions by @cderici in #873 * Forward port subordinate utils by @cderici in #880 * [JUJU-3952] Revisit access control levels by @cderici in #882 * [JUJU-3999] Avoid parsing endpoint for overlay offers by @cderici in #887 * Forward port upgrade resource fixes in app refresh by @cderici in #889 * [JUJU-4076] Rename `wait_for_units` and make semantics clearer by @cderici in #890 * Stabilize sphinx build on RTD by @cderici in #899 * Move test utils into a separate module by @cderici in #903 * Remove title prefixes from issue templates by @cderici in #904 * [JUJU-4048] Use GetChangesMapArgs for bundle changes by @jack-w-shaw in #907 * Forward ports from 2.9 to 3.x by @cderici in #910 * Remove ceiling on pyyaml version by @cderici in #918 [JUJU-3952]: https://warthogs.atlassian.net/browse/JUJU-3952?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-3999]: https://warthogs.atlassian.net/browse/JUJU-3999?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-4076]: https://warthogs.atlassian.net/browse/JUJU-4076?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-4048]: https://warthogs.atlassian.net/browse/JUJU-4048?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small forward-port that brings 138e53a, which moves the test utilities/constants into a separate file to be shared across all the integration tests (it used to be only in
integration/test_model.py).QA Steps
This is a simple move, no functionality change, however, the tests use those constants (some of are paths etc) so we should probably make sure no test in the CI is failing because of that.