style: type annotate constraints.py #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaqq
approved these changes
Oct 15, 2024
|
Let's rebase and merge this. |
Including:
- raising ValueError instead of Exception
- using `isinstance` instead of `type(...) is ...`
- multi-line continuation style
james-garner-canonical
force-pushed
the
2024-10/style/type-hint-constraints
branch
from
554ca7d
to
c49e474
Compare
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While looking into #1105, I found it useful to type annotate
juju/constraints.pywhile figuring out how things work.QA Steps
There should be no runtime changes in behaviour. Unit and integration tests should continue to pass, especially
tests/unit/test_constraints.py.Notes & Discussion
I also broke the longer regexes down across multiple lines and added comments to help me understand them.
I don't mind cutting this PR back to use more minimal type annotations, etc if that's deemed more appropriate in review (e.g. Dict[str, Union[int, float, bool]] instead of the custom TypedDicts).