Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VERY DRAFT] Dima's hacks #1097

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

[VERY DRAFT] Dima's hacks #1097

wants to merge 29 commits into from

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Aug 30, 2024

No description provided.

@jujubot
Copy link
Contributor

jujubot commented Aug 30, 2024

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial

1 similar comment
@jujubot
Copy link
Contributor

jujubot commented Aug 30, 2024

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial

@@ -738,9 +738,11 @@ class CAASApplicationProvisionerFacade(Type):
'name': {'type': 'string'}},
'type': 'object'},
'CharmContainer': {'additionalProperties': False,
'properties': {'mounts': {'items': {'$ref': '#/definitions/CharmMount'},
'properties': {'gid': {'type': 'integer'},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow adding client20 updated all the other clients, like client1 here.

I'm not sure what's going on, should these changes be pulled in or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants