feat: make some small improvements to make this easier to use. #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are mostly made out of anger.
jack-w-shaw
reviewed
Oct 11, 2024
|
|
||
| To build the job descriptions run: | ||
| ``` | ||
| JUJU_REPO_PATH="<juju-repo-on-branch-to-generate-jobs-from>" make gen-wire-tests |
There was a problem hiding this comment.
We have to generate from main atm
There was a problem hiding this comment.
That is a very good point. We should probably get gen-wire-tests to check the branch.
There was a problem hiding this comment.
It already does!
JUJU_REPO_PATH="/home/aflynn/Canonical/Juju/juju3/" make gen-wire-tests
2024/10/11 17:13:17 not on the tracking branch "main", or not update to date with HEAD
exit status 1
make: *** [Makefile:61: gen-wire-tests] Error 1
jack-w-shaw
approved these changes
Oct 11, 2024
SimonRichardson
approved these changes
Oct 11, 2024
|
|
||
| To build the job descriptions run: | ||
| ``` | ||
| JUJU_REPO_PATH="<juju-repo-on-branch-to-generate-jobs-from>" make gen-wire-tests |
There was a problem hiding this comment.
That is a very good point. We should probably get gen-wire-tests to check the branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are mostly made out of annoyance.
Includes an update to the jenkins job builder version to make it work with python 3.12.