Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to noble #196

Merged
merged 5 commits into from
Jul 7, 2024
Merged

chore: move to noble #196

merged 5 commits into from
Jul 7, 2024

Conversation

hpidcock
Copy link
Member

@hpidcock hpidcock commented Jul 5, 2024

This is a whole bunch of fun in one ugly PR.

  • update jenkins job builder to 6.3.0
  • fix all the issues around parameters vs templates
  • remove some legacy files
  • add a nix flake for development shell (mostly for me)
  • add move to noble

Copy link
Member

@wallyworld wallyworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. \o/

python_base_path = $(shell which python3)

.PHONY: ensure-venv
ensure-venv:
pip3 show virtualenv > /dev/null || pip3 install virtualenv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want this anymore?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python has built in venv module

@hpidcock hpidcock merged commit 66ff959 into juju:main Jul 7, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants