Build musl on arm64 for arm64. #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonRichardson
approved these changes
Sep 5, 2023
jujubot
added a commit
to juju/juju
that referenced
this pull request
Sep 7, 2023
#16196 This is both a merge PR and makes changes for actions to get it land-able. Changes: - Remove spew.Dump/fmt.Println debug logging in ec2 left by a recent PR. Ran `go mod tidy` - Enable the Upgrade job (it was turned off until 3.2.0 release), then turned it off again as it was getting to complex to fix in this PR. Will follow-up with a new PR to fix it and enable it for the first time on 3.2.0. - Change musl toolchain to select on target and host arch. Add new SHAs for amd64-on-amd64 and arm64-on-arm64. See juju/juju-qa-jenkins#158 - Drop s390x and ppc64le building here. They consume a lot of resources due to musl not being prebuilt and having to cross-compile. These builds will continue to be handled in jenkins jobs. - Drop most builds on "push". They consume action runners, and we don't even look at or alert on these jobs. Jenkins is testing what actually ends up being merged much better. (I will need to backport this change to 3.1 and 2.9) - Revert change made in #15969 for log tailing in `run.sh` Forward ports: - #16179 - #16122 - #16182 - #16183 - #15969 - #16186 - #15882 - #16200 - #16203 - #15878 - #16210 - #16204 Conflicts: - .github/workflows/client-tests.yml - .github/workflows/microk8s-tests.yml - .github/workflows/migrate.yml - .github/workflows/smoke.yml - .github/workflows/static-analysis.yml - .github/workflows/upgrade.yml - cmd/juju/application/scaleapplication.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To speed up builds on arm64 targeting arm64, lets prebuild musl.
See juju/juju#16196