Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect exported bundle #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Collect exported bundle #71

wants to merge 1 commit into from

Conversation

nobuto-m
Copy link
Contributor

Closes: #63

@jhobbs
Copy link
Contributor

jhobbs commented Dec 10, 2020

I think this should be behind a command line option. It will dump sensitive information like passwords and keys, which people might not expect.

@nobuto-m
Copy link
Contributor Author

I think this should be behind a command line option. It will dump sensitive information like passwords and keys, which people might not expect.

Hmm, juju-crashdump actually collects sensitive information out of the box including ".unit-state.db" which usually has TLS cert/key and some passwords. Sanitization is another topic, for example in #27, but I will look into separating out juju export-bundle behind another flag.

@jhobbs
Copy link
Contributor

jhobbs commented Jan 22, 2021

Ok; we probably should not be collecting .unit-state.db then.

Maybe one big "--include-potential-secrets" flag would be a good idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please include juju export-bundle
2 participants
@nobuto-m @jhobbs