Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ssh controller proxy #103

Merged
merged 11 commits into from
Oct 11, 2023
Merged

Use ssh controller proxy #103

merged 11 commits into from
Oct 11, 2023

Conversation

Sponge-Bas
Copy link
Contributor

Since recently, workloads on OpenStack controllers do not get a public IP. In order to still get the crashdumps for workloads on OpenStack we need to use the --proxy option when using juju scp or juju ssh. We need to make a proxy jump through the juju controllers for vanilla ssh commands. This requires slightly different ssh-key handling, which is assisted by the ssh-agent-setup package.

The unittests are updated from nose to pytest and the formatter black is run against all .py files.

Copy link
Contributor

@asbalderson asbalderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine
just some notes about leaving better comments etc about what the methods are doing.

jujucrashdump/crashdump.py Show resolved Hide resolved
jujucrashdump/crashdump.py Outdated Show resolved Hide resolved
Copy link
Contributor

@asbalderson asbalderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 ty

@Sponge-Bas Sponge-Bas merged commit 68f8c34 into juju:master Oct 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants