Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CI:
edge
onpush
.bootstrap
job tointegration
.Disable CI runs on
pull_request
:pull_request
runs to access secrets.Add a(EDIT: I deleted this workflow cause it really does not seem to work at all. Something weird about the way GitHub triggers actions).pr.yml
workflow which checks this.Enable CI on forks:
CHARM_NAME
variable, which can be set on a fork to upload the charm to a different URL.charmcraft_tokengen.sh
script, to allow contributors to easily generate theCHARMCRAFT_AUTH
secret for their forksQA steps
The new PR workflow should fail when run on a PR opened from a fork. See Test PR workflow #47Links
Jira card: JUJU-4663