-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD-9334 - fix: use callback resolve and reject #123
Merged
vladimir-cucu
merged 12 commits into
juju:master
from
vladimir-cucu:use-reject-resolve-callbacks
Mar 6, 2024
Merged
WD-9334 - fix: use callback resolve and reject #123
vladimir-cucu
merged 12 commits into
juju:master
from
vladimir-cucu:use-reject-resolve-callbacks
Mar 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-cucu
changed the title
fix: use callback resolve and reject
WD-9334 - fix: use callback resolve and reject
Mar 4, 2024
vladimir-cucu
added
Review: Code +1
Review: Code needed
and removed
Review: Code +1
labels
Mar 4, 2024
huwshimi
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some suggestions here.
huwshimi
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. You could also update the version number in package.json to 6.0.0 ready for release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Transport
instead of resolving withstring
for error and resolving with other type for successful request.Details