WD-8065 - Update facades for Juju 3.3 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huwshimi
commented
Jan 5, 2024
| @@ -271,7 +271,7 @@ class Client { | |||
| "user-data": "", | |||
| }; | |||
| const url = this._transport._ws.url; | |||
| const origin = new URL(url).origin; | |||
| const origin = url; | |||
There was a problem hiding this comment.
This was a drive-by fix to improve macaroon handling with the new JIMM.
There was a problem hiding this comment.
Everything inside the api folder is built automatically by the script.
README.md
Outdated
There was a problem hiding this comment.
These changes are made automatically by the script.
There was a problem hiding this comment.
This file is copied from Juju.
| "description": "Juju API client", | ||
| "main": "dist/api/client.js", | ||
| "types": "dist/api/client.d.ts", | ||
| "type": "module", | ||
| "scripts": { | ||
| "build": "tsc", | ||
| "clean": "rm -rf node_modules dist", | ||
| "generate-facades": "SCHEMA=generator/schema/schema.json JUJU_VERSION=$(cat generator/schema/juju-version.txt) JUJU_GIT_SHA=$(cat generator/schema/juju-git-sha.txt) ts-node generator/index.ts", | ||
| "generate-facades": "SCHEMA=generator/schema/schema.json JUJU_VERSION=$(cat generator/schema/juju-version.txt) JUJU_GIT_SHA=$(cat generator/schema/juju-git-sha.txt) node --no-warnings=ExperimentalWarning --loader ts-node/esm generator/index.ts", |
There was a problem hiding this comment.
This change was required as ts-node was having issues with Node > v16.
vladimir-cucu
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Details
https://warthogs.atlassian.net/browse/WD-8065