Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for regex style trigger #26

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

nskaggs
Copy link

@nskaggs nskaggs commented Sep 14, 2016

This is a straight diff of what is being utilized for juju. I'm not sure about the setup.py changes.

@jujugui
Copy link
Contributor

jujugui commented Sep 14, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/jenkins-github-lander/57/
Test FAILed.

@@ -255,3 +256,4 @@ def user_is_in_org(user, org, request_info):
log.debug(" Ensure {}'s membership in {} is public".format(
user, org))
return False

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove any extra lines

Copy link
Contributor

@mitechie mitechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, will look again with test updates. One comment and 👍 otherwise.

Remove extra lines
Remove extra lines
@jujugui
Copy link
Contributor

jujugui commented Sep 14, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/jenkins-github-lander/58/
Test FAILed.

@jujugui
Copy link
Contributor

jujugui commented Sep 14, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/jenkins-github-lander/59/
Test FAILed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants