Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin the version of path since 17.0 removed deprecated methods #675

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Pin the version of path since 17.0 removed deprecated methods #675

merged 1 commit into from
Jul 31, 2024

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Jul 31, 2024 •
edited
Loading

With path==17.0.0, some methods have been deprecated which were in use by this project

Since path.py was just a direct install of path with no restrictions, lets just remove path.py and pin path

jaraco/path@7e23a1d

Checklist

  • Are all your commits [logically] grouped and squashed appropriately?
  • Does this patch have code coverage?
  • Does your code pass make test?

@addyess
Copy link
Contributor Author

addyess commented Jul 31, 2024

Resolves issue #674

@wallyworld wallyworld merged commit 0c02af3 into juju:master Jul 31, 2024
6 checks passed
xtrusia pushed a commit to xtrusia/charm-tools that referenced this pull request Sep 23, 2024
@addyess @xtrusia
Pin the version of path since 17.0 removed deprecated methods (juju#675)
1cb65ff 
(cherry picked from commit 0c02af3)
Signed-off-by: Seyeong Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyworld wallyworld wallyworld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyess @wallyworld