Support checking service ports with ssl connection #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosaboy
force-pushed
the
bug/1920770
branch
3 times, most recently
from
bd09435
to
70a0059
Compare
dosaboy
force-pushed
the
bug/1920770
branch
2 times, most recently
from
8ac0bca
to
5ba196e
Compare
brianphaley
approved these changes
Mar 20, 2024
mkalcok
suggested changes
Apr 11, 2024
nicolasbock
approved these changes
Apr 11, 2024
dosaboy
force-pushed
the
bug/1920770
branch
7 times, most recently
from
22ef771
to
c97b780
Compare
mkalcok
approved these changes
Apr 12, 2024
By default netcat is used to check if a service is listening on a port. This is generally ok except for services expecting SSL connections which need to be properly closed and netcat can't do that. So here we add support for optionally using the python ssl library to create an ssl connection to the port and close it properly once finished. Related-Bug: #1920770
javacruft
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related-Bug: #1920770