Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/yoga] Fix pep8 error in assert type comparison #844

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[stable/yoga] Fix pep8 error in assert type comparison #844

merged 1 commit into from
Sep 5, 2023

Conversation

rodrigogansobarbieri
Copy link
Contributor

charmhelpers/fetch/snap.py:55:12: E721 do not compare types, for exact checks use is / is not,
for instance checks use isinstance()

(cherry picked from commit 5b0a3e6)
(cherry picked from commit 452988f)

@rodrigogansobarbieri
Fix pep8 error in assert type comparison
d0a54fc 
charmhelpers/fetch/snap.py:55:12: E721 do not compare types,
for exact checks use `is` / `is not`,
for instance checks use `isinstance()`

(cherry picked from commit 5b0a3e6)
(cherry picked from commit 452988f)
@ajkavanagh ajkavanagh merged commit 910c898 into juju:stable/yoga Sep 5, 2023
3 checks passed
@ajkavanagh
Copy link
Contributor

Merged on a single approval on stable branch as it is, in effect, a no-op to keep pep8 happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkavanagh ajkavanagh ajkavanagh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodrigogansobarbieri @ajkavanagh