Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/antelope] Add name parameter to send_application_name #841

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[stable/antelope] Add name parameter to send_application_name #841

merged 1 commit into from
Sep 19, 2023

Conversation

rodrigogansobarbieri
Copy link
Contributor

This way, multiple nova-compute applications can
share the same ceph key, as nova can invoke
send_application_name('nova-compute').

(cherry picked from commit 6a19a0a)

ajkavanagh
ajkavanagh approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@ajkavanagh ajkavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that it's either two cherry-picks or a change and a cherry-pick as there are two commits. However, they do match more recent branch changes.

@rodrigogansobarbieri
Add name parameter to send_application_name
c29362d 
This way, multiple nova-compute applications can
share the same ceph key, as nova can invoke
send_application_name('nova-compute').

(cherry picked from commit 6a19a0a)
(cherry picked from commit 1f3393a)
@rodrigogansobarbieri
Copy link
Contributor Author

rebased on top of stable/antelope so the PR is now just 1 commit

coreycb
coreycb approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@coreycb coreycb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs one more core reviewer to land

@ajkavanagh ajkavanagh merged commit fe47771 into juju:stable/antelope Sep 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkavanagh ajkavanagh ajkavanagh approved these changes

@coreycb coreycb coreycb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigogansobarbieri @ajkavanagh @coreycb