Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove f-strings, fix pep8 error, and py311 to matrix #839

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

ajkavanagh
Copy link
Contributor

@ajkavanagh ajkavanagh commented Aug 8, 2023

  • Remove the f-strings; this caused problems with py3.5 which the
    library sort-of still supports.
  • Fix the newest pep8 error.
  • Add py311 testing the tox; not quite ready for github in this PR.

@ajkavanagh ajkavanagh force-pushed the remove-f-string branch 2 times, most recently from 9bd3fbe to 92ca4d2 Compare August 8, 2023 08:55
- Remove the f-strings; this caused problems with py3.5 which the
  library sort-of still supports.
- Fix the newest pep8 error.
- Add py311 testing to the matrix.
@jadonn
Copy link

jadonn commented Aug 8, 2023

The commit looks good to me, but someone else will have to sign off on merging the change.

@freyes freyes mentioned this pull request Aug 8, 2023
tox.ini Show resolved Hide resolved
@freyes freyes merged commit 02ee3d1 into master Aug 8, 2023
4 checks passed
@freyes freyes deleted the remove-f-string branch August 8, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants