Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update method for checking endpoint protocol #769

Merged
merged 4 commits into from
May 4, 2023

Commits on Apr 19, 2023

  1. Update method for checking endpoint protocol

    The `https` method is used to check if an endpoint is expected to
    be http or https. One of the checks it performs is to examine the
    the certificates relation. If the relation is present then it looks
    for the existance of a CA. However the OpenStack charms do not
    switch to https until a certificate is provided via the certificates
    relation. This means there can be a disconnect if the
    certificate provider has provided a CA but has not yet provided
    the unit specific certificates. If this happens then the payload
    will still be using http but the `https` method will return True.
    
    This patch updates the `https` method to return False if an unfilled
    certificate request exists.
    Liam Young committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    73dc31c View commit details
    Browse the repository at this point in the history
  2. Use local import instead of code duplication

    Liam Young committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    0b88a96 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Update unit tests

    Liam Young committed May 3, 2023
    Configuration menu
    Copy the full SHA
    53677e3 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Fix unit test

    Liam Young committed May 4, 2023
    Configuration menu
    Copy the full SHA
    8f0647f View commit details
    Browse the repository at this point in the history