Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge fuse image to mount & update 1.2 Dockerfile to go1.20 #990

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

zwwhdls
Copy link
Member

@zwwhdls zwwhdls commented Jun 20, 2024

  1. merge fuse image to mount
  2. rename ce.juicefs-1.2.Dockerfile to ce.juicefs.Dockerfile
  3. rename ce.juicefs.Dockerfile to ce.juicefs-1.1.Dockerfile
  4. update 1.2 Dockerfile to go1.20

@zwwhdls zwwhdls requested review from timfeirg and zxh326 June 20, 2024 03:25
@@ -42,3 +42,6 @@ RUN jfs_mount_path=${JFS_MOUNT_PATH} && \
chmod +x ${jfs_mount_path} && cp juicefs.py ${JUICEFS_CLI} && chmod +x ${JUICEFS_CLI}

RUN /usr/bin/juicefs version

ENV K8S_VERSION v1.14.8
RUN curl -o /usr/local/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/${K8S_VERSION}/bin/linux/${TARGETARCH}/kubectl && chmod +x /usr/local/bin/kubectl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need kubectl in mount image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's need in fuse image which is for Fluid. This PR merged the two in order to better maintain the image in the future.

Copy link
Member

@zxh326 zxh326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m concerned that this might cause the mount image size to keep growing

@zwwhdls
Copy link
Member Author

zwwhdls commented Jun 21, 2024

There will be only a dozen M of growth, and no other unnecessary packages will be added.

@zwwhdls zwwhdls merged commit 3ae50f3 into master Jun 21, 2024
25 checks passed
@zwwhdls zwwhdls deleted the ci/fix_ce_goversion branch June 21, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants